Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle NullPointerException #102

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Conversation

sridamul
Copy link
Contributor

Closes #101

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
    - [ ] Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@sridamul sridamul requested a review from a team as a code owner July 17, 2024 07:25
Copy link
Collaborator

@gounthar gounthar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are currently losing important information about missing files in our error messages. While the system informs users that no plugins were found, (Error reading plugins from file: plugins.txt) it fails to explicitly state that this is due to a missing file. Should we go to this level of details?

java -jar plugin-modernizer-cli/target/jenkins-plugin-modernizer-999999-SNAPSHOT.jar --dry-run --plugin-file plugins.txt  --recipes AddPluginsBom,AddCodeOwner 
Picked up JAVA_TOOL_OPTIONS: -XX:+UseContainerSupport -XX:ActiveProcessorCount=1
Error reading plugins from file: plugins.txt 
Starting Plugin Modernizer 
Picked up JAVA_TOOL_OPTIONS: -XX:+UseContainerSupport -XX:ActiveProcessorCount=1
Plugins: [] 
Recipes: [AddPluginsBom, AddCodeOwner] 
GitHub owner: gounthar 

@sridamul sridamul requested a review from gounthar July 17, 2024 09:13
Copy link
Collaborator

@gounthar gounthar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this works for me.

@gounthar gounthar merged commit 165397e into jenkins-infra:main Jul 17, 2024
13 checks passed
@sridamul sridamul deleted the fix/issue-101 branch July 17, 2024 09:19
@jonesbusy jonesbusy added the bug For changelog: Minor bug. Will be listed after features label Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Minor bug. Will be listed after features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

java.lang.NullPointerException: Cannot invoke "java.util.Collection.toArray()" because "c" is null
3 participants