Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(terraform) Remove parameter agentContainerImage in favor of agentLabel #817

Merged
merged 11 commits into from
Jan 19, 2024

Conversation

smerle33
Copy link
Contributor

@smerle33 smerle33 commented Jan 3, 2024

Change in the pipeline shared library to start using labelled arm64 agent instead of PodTemplate
as per jenkins-infra/helpdesk#3823 (comment)

vars/terraform.groovy Outdated Show resolved Hide resolved
@smerle33 smerle33 marked this pull request as ready for review January 9, 2024 13:30
@smerle33 smerle33 requested review from a team and dduportal January 9, 2024 13:30
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, but more work is required:

  • Title need to be updated
  • Need to update documentation
  • Need to run a fully fledged test with a PR on one of the terraform jobs

@smerle33 smerle33 marked this pull request as draft January 9, 2024 16:18
smerle33 added a commit to jenkins-infra/azure that referenced this pull request Jan 10, 2024
@smerle33
Copy link
Contributor Author

@smerle33 smerle33 changed the title wip change agent to arm64 wip change containerImage to agent label to allow arm64 usage Jan 15, 2024
@smerle33
Copy link
Contributor Author

using this PR to test on AZURE : https://infra.ci.jenkins.io/job/terraform-jobs/job/azure/job/PR-575

vars/terraform.groovy Outdated Show resolved Hide resolved
smerle33 added a commit to jenkins-infra/shared-tools that referenced this pull request Jan 19, 2024
@smerle33
Copy link
Contributor Author

followed by jenkins-infra/shared-tools#136 to update documentation

@smerle33 smerle33 marked this pull request as ready for review January 19, 2024 08:02
@smerle33 smerle33 requested a review from dduportal January 19, 2024 08:02
@smerle33 smerle33 changed the title wip change containerImage to agent label to allow arm64 usage Change containerImage to agent label to allow arm64 usage Jan 19, 2024
@smerle33 smerle33 changed the title Change containerImage to agent label to allow arm64 usage Change containerImage to agent label to allow arm64 usage with AllInOne agent Jan 19, 2024
@dduportal dduportal changed the title Change containerImage to agent label to allow arm64 usage with AllInOne agent feat(terraform) Remove parameter agentContainerImage in favor of agentLabel Jan 19, 2024
@smerle33 smerle33 merged commit a1f77fa into jenkins-infra:master Jan 19, 2024
4 checks passed
@smerle33 smerle33 deleted the agent/to/arm64 branch January 19, 2024 13:18
smerle33 added a commit to jenkins-infra/shared-tools that referenced this pull request Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants