Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mirrorbits) add ingress for mirrors.jenkins.io - jenkins-infra/helpdesk#2888 #2329

Merged
merged 1 commit into from
May 5, 2022

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented May 5, 2022

This change request is related to jenkins-infra/helpdesk#2888.

It adds another ingress rule for the mirrorbits service, along with the current get.jenkins.io.

Please note that:

  • TLS certificates will be generated without any problem, like it was done for rating.jenkins.io in feat(rating): new release for rating #2137 : cert manager uses an ACME DNS resolver.
  • Once deployed, This change will be testable by adding an entry 52.167.253.43 mirrors.jenkins.io in your /etc/hosts file, until the DNS mirrors.jenkins.io is changed to a CNAME on public.aks.jenkins.io (which is a A 52.167.253.43, hence the hosts entry)

@dduportal dduportal marked this pull request as ready for review May 5, 2022 12:57
@dduportal dduportal requested a review from a team May 5, 2022 12:57
timja
timja previously approved these changes May 5, 2022
@dduportal dduportal marked this pull request as draft May 5, 2022 15:15
@dduportal dduportal force-pushed the feat/helpdesk-2888 branch from ecfb0ed to 998393e Compare May 5, 2022 15:16
@dduportal dduportal requested a review from timja May 5, 2022 15:17
@dduportal dduportal marked this pull request as ready for review May 5, 2022 15:17
@dduportal
Copy link
Contributor Author

Woops I did a typo on the domain name. Fixed (was missing the sof mirror)

@dduportal dduportal enabled auto-merge (squash) May 5, 2022 15:17
@dduportal dduportal disabled auto-merge May 5, 2022 16:02
@dduportal dduportal merged commit cf2a7f8 into jenkins-infra:main May 5, 2022
@dduportal dduportal deleted the feat/helpdesk-2888 branch May 5, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants