-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated UI screenshots for the Using credentials page #7621
Updated UI screenshots for the Using credentials page #7621
Conversation
Thanks for submitting this @yashpal2104, I'm just trying to generate a deploy preview site so that I can check how the images are rendering on the page before I review. |
…sed on the new updated screenshots
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much @yashpal2104, the work is very much appreciated.
Unfortunately, it appears that the manage_credentials screenshot is extremely large (2798 x 1691) and should be shrunk a bit. I've cropped and shrunk the image quite a bit to make it better fit the contributing guidelines, and it is more focused in terms of the related content. I've also compressed it as it was still reading almost 300 kb according to compressor.io
@yashpal2104 no worries, so the green text that says "80 kb" is saying that it is an additional 80 kb to what the original screenshot was in terms of size. So the original screenshot would be somewhere around ~215 kb. When the screenshot being uploaded is smaller than the existing one, those numbers will show up as red. It can definitely be a bit confusing and that is something that I didn't realize right away, but it's helpful information to know. |
oh okay now I understand, thanks for clarifying this |
Is this ready to be merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these all look good, thank you very much @yashpal2104. The work is greatly appreciated
fixes #7525 updated the screenshots used to the latest ones