Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated UI screenshots for the Using credentials page #7621

Merged
merged 4 commits into from
Oct 22, 2024

Conversation

yashpal2104
Copy link
Contributor

fixes #7525 updated the screenshots used to the latest ones

@yashpal2104 yashpal2104 requested a review from a team as a code owner October 17, 2024 18:11
@kmartens27
Copy link
Contributor

Thanks for submitting this @yashpal2104, I'm just trying to generate a deploy preview site so that I can check how the images are rendering on the page before I review.

Copy link
Contributor

@kmartens27 kmartens27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much @yashpal2104, the work is very much appreciated.

Unfortunately, it appears that the manage_credentials screenshot is extremely large (2798 x 1691) and should be shrunk a bit. I've cropped and shrunk the image quite a bit to make it better fit the contributing guidelines, and it is more focused in terms of the related content. I've also compressed it as it was still reading almost 300 kb according to compressor.io

manage-credentials

@yashpal2104
Copy link
Contributor Author

yashpal2104 commented Oct 18, 2024

Oh I am sorry. I should have taken only the necessary and focussed image I will remember it the next time. But I dont know how is it showing 300kb while here it says 80kb
Screenshot from 2024-10-18 20-57-40

@kmartens27
Copy link
Contributor

@yashpal2104 no worries, so the green text that says "80 kb" is saying that it is an additional 80 kb to what the original screenshot was in terms of size. So the original screenshot would be somewhere around ~215 kb. When the screenshot being uploaded is smaller than the existing one, those numbers will show up as red. It can definitely be a bit confusing and that is something that I didn't realize right away, but it's helpful information to know.

@yashpal2104
Copy link
Contributor Author

oh okay now I understand, thanks for clarifying this

@yashpal2104
Copy link
Contributor Author

yashpal2104 commented Oct 21, 2024

Is this ready to be merged?
@kmartens27

Copy link
Contributor

@kmartens27 kmartens27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these all look good, thank you very much @yashpal2104. The work is greatly appreciated

@kmartens27 kmartens27 merged commit fddb922 into jenkins-infra:master Oct 22, 2024
6 of 7 checks passed
@yashpal2104 yashpal2104 deleted the using-credential branch October 22, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update UI screenshots in Using Jenkins documentation
2 participants