-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Blog post] Introducing the 2 + 2 + 2 Java support plan #6809
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small optional suggestion, great blog post!
content/blog/2023/11/2023-11-06-introducing-2-2-2-java-support-plan.adoc
Outdated
Show resolved
Hide resolved
content/blog/2023/11/2023-11-06-introducing-2-2-2-java-support-plan.adoc
Outdated
Show resolved
Hide resolved
…-plan.adoc Co-authored-by: Hervé Le Meur <[email protected]>
…-plan.adoc Co-authored-by: Hervé Le Meur <[email protected]>
The Gantt charts aren't being rendered, so once the content is finalized I will convert them to rendered images. I'll wait until after the content is finalized to ensure that I only have to do this a single time. If anyone has any better ideas about how to make the static site generator render the Gantt charts, let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
I added an opengraph image in 79ced5f so that the list of pages would have a picture to describe the blog post. The picture was created from the Jenkins social media covers slide deck
I looked into trying to have Asciidoctor render the Gantt charts via So given the above, I ran |
I have checked the preview site and confirmed the rendered SVG Gantt charts are displaying correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks very much @basil.
I noted one small suggestion regarding a line, but outside of that everything looks good to me and the charts are rendering nicely.
This plan balances the needs of large scale users for predictability and stability | ||
with the needs of early adopters and developers | ||
to improve and simplify Jenkins with the latest Java capabilities | ||
and to reduce the maintenance overhead associated with a large build and test matrix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This plan balances the needs of large scale users for predictability and stability | |
with the needs of early adopters and developers | |
to improve and simplify Jenkins with the latest Java capabilities | |
and to reduce the maintenance overhead associated with a large build and test matrix. | |
This plan balances the needs of large scale users for predictability and stability, | |
with the needs of early adopters and developers, | |
to improve and simplify Jenkins with the latest Java capabilities | |
and to reduce the maintenance overhead associated with a large build and test matrix. |
Small suggestion to add some punctuation for sentence structure/avoiding a run on sentence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A run-on sentence occurs when two independent clauses run together without proper punctuation or appropriate conjunctions. A clause requires both a subject and a verb. This sentence has only one subject: "plan". The only other nouns in this sentence are functioning as direct objects or objects of prepositions. So there is no run-on sentence here.
This plan balances the needs of A for B with the needs of C to D and to E.
A = large scale users
B = predictability and stability
C = early adopters and developers
D = improve and simplify Jenkins with the latest Java capabilities
E = reduce the maintenance overhead associated with a large build and test matrix
Adopting your suggestion would result in the structure
This plan balances the needs of A for B, with the needs of C, to D and to E.
This places commas before two prepositions, which is grammatically incorrect for the reasons given in https://thecriticalreader.com/no-comma-before-or-after-a-preposition/
External user-facing communication about the 2 + 2 + 2 Java support plan, including the relevant upcoming dates as well as a practical discussion about the tradeoffs involved in making this decision.
Testing done
Viewed https://github.com/basil/jenkins.io/blob/java-blog-post/content/blog/2023/11/2023-11-06-introducing-2-2-2-java-support-plan.adoc and confirmed the content was readable and the dates were accurate.