Note when people may have gotten a bad release-drafter config #4965
Conversation
I was surprised to see that the config that needs changing is part of the archetype.
probot-autolabeler
bot
added
the
documentation
| @@ -56,7 +56,9 @@ _extends: .github | |||
| Make sure to remove any `tag-template` override that may have been configured previously. | |||
|
|
|||
| Delete `.github/workflows/release-drafter.yml` if you previously enabled Release Drafter using the GitHub Actions, | |||
| or link:https://github.com/apps/release-drafter/installations/775283[remove the App from the repository] if it was configured that way. | |||
There was a problem hiding this comment.
Removed trailing space.
Why would that be surprising? We do not currently enable JEP-229 in the archetype, and for MRP-based plugins the archetype defines the recommended RD config. |
It is, however, the recommended way to release: https://www.jenkins.io/doc/developer/publishing/releasing/
The archetype setting things up one way and then making people change it immediately when following the recommendations is surprising. |
|
Ah I did not see that #4341 actually recommended it. We could enable JEP-229 in archetypes for new plugins, when the @jenkinsci mode is enabled, though we would then need to also ensure that CD is enabled in RPU by default for newly hosted plugins I think. Also probably we would want to do jenkins-infra/jenkins-maven-cd-action#10 first so that we are not pushing a stale config. |
I was surprised to see that the config that needs changing is part of the archetype.