-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy www.jenkins.io on Azure #1117
Conversation
Jenkinsfile
Outdated
@@ -74,6 +78,16 @@ try { | |||
''' | |||
} | |||
} | |||
stage('Build Docker Image') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way we can avoid re-building the Docker image every single Pipeline run? I'm assuming that this nginx container will change very infrequently, while the jenkins.io content is rebuilt every few minutes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No there isn't, either we rebuild this image every pipeline run, either we move this docker image to another Github repository.
As this image is not specific to www.jenkins.io, we may consider to move it into another project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough, let's move it into another repository then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, @olblak feel free to merge once the credential is added to trusted.ci
Require credential 'BLOBXFER_STORAGEACCOUNTKEY' set to the storage account key of 'prodjenkinsio'
Require: