cleanup: remove superseded blobxfer variable and checks #3372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dduportal
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
AZURE_STORAGE_ACCOUNTvariable previously used by blobxfer in pkg sync scripts (its value is also inSTORAGE_NAME, used by the get-fileshare-signed-url.sh script) and associated checks that were added to pass shellcheck before implementing azcopy as replacement of blobxfer in jenkins-infra/mirror-scripts#14.Verification procedure after merging this PR: ensure update_center job still passes on trusted.ci.jenkins.io
Ref:
blobxferbyazcopyhelpdesk#3414 (comment)