[JENKINS-49707] Pick up proposed final changes #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dduportal
approved these changes
Oct 11, 2022
|
Is this live? Any issues noticed so far? |
|
No one screaming bloody regression so far, so I guess it is OK. |
|
Hey sorry @jglick for the delayed answer. So yes it is live in infra.ci.jenkins.io since ~7 days and no issues. We can proceed to release, unless you want also a test on ci.jenkins.io itself? |
|
Thanks. I am proceeding to release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up #512 and countermanding #532 if you are willing to run these prior to release @dduportal. Picks up jenkinsci/workflow-api-plugin#256 + jenkinsci/workflow-durable-task-step-plugin#180. Briefly, this would make it possible for
retryblocks to work even if the agent outage was detected during a controller restart, as might occur for example during cluster updates (draining node pools, that sort of thing).