hotfix(privatek8s): no upgrade_settings for spot instances node pools #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dduportal
approved these changes
Jun 18, 2024
smerle33
added a commit
that referenced
this pull request
Jun 18, 2024
following #730 need some formatting
dduportal
added a commit
that referenced
this pull request
Jun 18, 2024
…r-ending updated attribute (#732) Follow up of #727 , #730 and #731 This fixes the never-ending changed attribute `upgrade_settings {}` for the 2 Spot node pools on `privatek8s`. It follows the tip found in hashicorp/terraform-provider-azurerm#24020 (comment) to avoid having all of our plans trying to change the 2 node pools. Signed-off-by: Damien Duportal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixup #727 no upgrade_settings for spot instances :