Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(infraci/cluster/sponsored): Add admin service account and token #722

Merged
merged 1 commit into from
Jun 11, 2024
Merged

feat(infraci/cluster/sponsored): Add admin service account and token #722

merged 1 commit into from
Jun 11, 2024

Conversation

smerle33
Copy link
Collaborator

as per jenkins-infra/helpdesk#3923 (comment)

Plan: 3 to add, 0 to change, 0 to destroy.

add:

  • kubernetes_cluster_role_binding
  • kubernetes_secret
  • kubernetes_service_account

@smerle33 smerle33 requested a review from a team June 11, 2024 12:00
dduportal
dduportal approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plan: 3 to add, 0 to change, 0 to destroy.

LGTM!

Note: I'm not convinced of the output for this cluster, but not blocker

@smerle33 smerle33 merged commit fce7e5f into jenkins-infra:main Jun 11, 2024
3 checks passed
@smerle33 smerle33 mentioned this pull request Jun 11, 2024
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dduportal dduportal dduportal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smerle33 @dduportal