feat(updates.jenkins.io) restrict SA to only a few administrative IPs #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Damien Duportal <[email protected]>
Signed-off-by: Damien Duportal <[email protected]>
dduportal
commented
Jan 6, 2024
dduportal
added a commit
that referenced
this pull request
Jan 6, 2024
… and should not disable public access to apply restriction (#571) Fixup of #570 Related to jenkins-infra/helpdesk#2649 and jenkins-infra/helpdesk#3875 Signed-off-by: Damien Duportal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to both jenkins-infra/helpdesk#2649 (comment) and jenkins-infra/helpdesk#3875
It restricts the Azure SA used for updates.jenkins.io to only a few administrative IPs including trusted.ci's 2 networks.
It also allows trusted.ci new network (sponsored) agents to access publick8s controler (for update center)