feat(ci.jenkins.io) add a custom controller RG in the new subscription to store agent NSG #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n to store agent NSG Signed-off-by: Damien Duportal <[email protected]>
dduportal
changed the title
dduportal
commented
Nov 22, 2023
dduportal
added a commit
that referenced
this pull request
Nov 22, 2023
…he proper provider (#521) Related to https://github.com/jenkins-infra/helpdesk/milestone/91 This PR fixes up #519 and #520 - Fixup of #520 by adding the proper provider to correct the error ``` │ Error: A resource with the ID "/subscriptions/****/resourceGroups/ci-jenkins-io-controller" already exists - to be managed via Terraform this resource needs to be imported into the State. Please see the resource documentation for "azurerm_resource_group" for more information. ``` - Allow specifying a custom storage account name for the new RG in the subscription as storage account name are scope to ALL Azure :'( to correct the error ``` │ Storage Account Name: "cijenkinsioagents"): storage.AccountsClient#Create: Failure sending request: StatusCode=409 -- Original Error: Code="StorageAccountAlreadyTaken" Message="The storage account named cijenkinsioagents is already taken." ``` - Cleanup of the `moved` declaration from #516 --------- Signed-off-by: Damien Duportal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to jenkins-infra/helpdesk#3818
Fixup of #519 to correct the error
Note that permissions have been increased to the SP to correct the following errors seen on the main branch: