Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a python 3.10 trove #266

Merged
merged 4 commits into from
Oct 27, 2021
Merged

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Oct 27, 2021

Added a python 3.10 trove for pypi - as I'm running this without issue in CI with 3.10.

  • I have updated the documentation in the README.md file or my changes don't require an update.
  • I have added an entry in CHANGELOG.md.
  • I have added or adapted tests to cover my changes.
  • I have run tox -e fix-style to format my code and checked the result with tox -e style.

Added a python 3.10 trove for pypi - as I'm running this without issue in CI with 3.10.
@chayim
Copy link
Contributor Author

chayim commented Oct 27, 2021

I haven't executed on all the items within the checklist as tests and tox style checks seem to not apply here.

@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2021

Codecov Report

Merging #266 (bdd6541) into master (6ffd70a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #266   +/-   ##
=======================================
  Coverage   99.37%   99.37%           
=======================================
  Files          18       18           
  Lines         635      635           
=======================================
  Hits          631      631           
  Misses          4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ffd70a...bdd6541. Read the comment docs.

@jendrikseipp
Copy link
Owner

Thanks for the PR! Before marking Python 3.10 as supported, I'd like to enable CI tests for it, however. Do you think you could make the necessary changes (in tox.ini and .github/workflows/main.yml)? Afterwards, please add an entry to the changelog.

@chayim
Copy link
Contributor Author

chayim commented Oct 27, 2021

Perfect, happy to, I just didn't want to presume ;). It's included in the latest push.

@jendrikseipp
Copy link
Owner

It seems the tests are not passing. Can you look into this, please?

@jendrikseipp jendrikseipp merged commit b8cbc44 into jendrikseipp:master Oct 27, 2021
@jendrikseipp
Copy link
Owner

Looks good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants