Use pathlib

[ju-sh]

Use pathlib

Description

• Use pathlib for path operations.
• Add some type annotations.

Related Issue

Mentioned at #224.

Checklist:

• I have updated the documentation in the README.md file or my changes don't require an update.
• I have added an entry in CHANGELOG.md.
• I have added or adapted tests to cover my changes.

[ju-sh]

Hi.

Coverage has reduced but I thought it was better to see if the changes were okay before adding to the tests as I have probably broken something.

[jendrikseipp]

Thanks for the patch! I had a quick look and the pathlib code looks good. However, reviewing this in more detail is hard, because most of the changes relate to adding type annotations. I haven't made up my mind about whether type annotations are useful for Vulture completely (given that it's primarily used as an app, not a library and has 100% test coverage), but I'm leaning towards adding them, at least where they make understanding the code easier. Therefore, I'd ask you to remove the type annotations, type imports and changes only related to mypy for now. Maybe you can store the diff related to types somewhere, for a separate PR. Depending on how separated your commits are, this may be easiest to to with a graphical diff tool like "meld".

[ju-sh]

Sorry for the delay. Got held up with something else in between.

I had ended up adding annotations to help me figure out the changes to make. I've removed them.

But, as an aside, I think it's good to have type annotations. They can really help a lot while making changes. Even when we don't do static type checking.

Let me know of further changes so we can go ahead and squash the commits.

[jendrikseipp]

After the rebase, please go over the diff and check that only pathlib-related changes are present. For example, I still saw some type annotations, which make reviewing hard.

[jendrikseipp]

This looks much nicer :-) I think with my proposed changes, we can get rid of some pathlib->string conversions, which should make the code cleaner.

[jendrikseipp]

Thanks for your work on this!