-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement auth mechanism for FHIR IG Importer #318
Implement auth mechanism for FHIR IG Importer #318
Conversation
Caution Review failedThe pull request is closed. WalkthroughThe recent updates enhance the FHIR IG Importer project by introducing two new configuration parameters, Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- fhir-ig-importer/docker-compose.yml (1 hunks)
- fhir-ig-importer/package-metadata.json (1 hunks)
Additional comments not posted (1)
fhir-ig-importer/docker-compose.yml (1)
24-25
: LGTM!The addition of
OPENHIM_API_USERNAME
andOPENHIM_API_PASSWORD
as environment variables is a good practice for managing sensitive information.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- fhir-ig-importer/package-metadata.json (1 hunks)
Files skipped from review due to trivial changes (1)
- fhir-ig-importer/package-metadata.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good just one minor comment
fcd6f9d
to
c1379b0
Compare
Summary by CodeRabbit
New Features
OPENHIM_API_USERNAME
andOPENHIM_API_PASSWORD
.Documentation
Linked to https://github.com/jembi/fhir-ig-importer/pull/6