Bug fixes #311
Bug fixes #311
Conversation
The jempi ui should communicate with jempi-api-kc service when keycloak integration is enabled
WalkthroughThe recent changes span across multiple configuration files, addressing SSH key additions, Nginx reverse proxy adjustments, and docker-compose corrections. Specifically, new SSH keys were added for two users, upstream server variables in Nginx were updated, a typo in a docker-compose file was fixed, and an environment variable for a service was corrected. Additionally, a service was removed, and formatting adjustments were made in a feature file. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- infrastructure/ansible/inventories/development/group_vars/all.yml (2 hunks)
- reverse-proxy-nginx/package-conf-insecure/http-jempi-insecure.conf (1 hunks)
- reverse-proxy-nginx/package-conf-secure/http-jempi-secure.conf (1 hunks)
Additional comments not posted (2)
reverse-proxy-nginx/package-conf-insecure/http-jempi-insecure.conf (1)
18-18: Change in upstream server variable approved.reverse-proxy-nginx/package-conf-secure/http-jempi-secure.conf (1)
62-62: Change in upstream server variable approved.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- client-registry-jempi/docker-compose.dgraph-zero-cluster.yml (1 hunks)
Files skipped from review due to trivial changes (1)
- client-registry-jempi/docker-compose.dgraph-zero-cluster.yml
It seems the bootstrapper does not cater for a replicated postgres url.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- client-registry-jempi/docker-compose.combined.yml (1 hunks)
Additional comments not posted (1)
client-registry-jempi/docker-compose.combined.yml (1)
114-114: Verify the usage of the new environment variable${POSTGRES_SERVICE}.Verification successful
Re-run the verification script with corrected file type handling.
The verification script confirms that the
${POSTGRES_SERVICE}variable is consistently used across multiple Docker Compose files. This indicates that the change to thePOSTGRESQL_IPenvironment variable in thejempi-bootstrapperservice is aligned with the rest of the configuration.
- : The change to use
${POSTGRES_SERVICE}for thePOSTGRESQL_IPenvironment variable is consistent with the usage across other Docker Compose files.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the definition and usage of `${POSTGRES_SERVICE}` across Docker Compose files. # Test: Search for the variable usage. Expect: Consistent usage across files. rg --type yaml --type yml $'POSTGRES_SERVICE' --files-with-matches | xargs cat | grep 'POSTGRES_SERVICE'Length of output: 129
Script:
#!/bin/bash # Description: Verify the definition and usage of `${POSTGRES_SERVICE}` across Docker Compose files. # Test: Search for the variable usage. Expect: Consistent usage across files. rg --type-add 'yaml:*.yml' --type yaml 'POSTGRES_SERVICE' --files-with-matches | xargs cat | grep 'POSTGRES_SERVICE'Length of output: 331
|
Hi Team. Any idea as to when this could be merged in? I see the tests are failing, although Im not sure why due to the changes in the PR. |
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- test/cucumber/features/cluster-mode/openhim-packages.cluster.feature (1 hunks)
Files skipped from review due to trivial changes (1)
- test/cucumber/features/cluster-mode/openhim-packages.cluster.feature
Summary by CodeRabbit
New Features
Bug Fixes
Configuration Changes
Chores