TB-173 Handle transactions stuck in processing state #1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1208 +/- ##
==========================================
+ Coverage 86.81% 86.83% +0.02%
==========================================
Files 87 87
Lines 5906 5916 +10
==========================================
+ Hits 5127 5137 +10
Misses 779 779
☔ View full report in Codecov by Sentry. |
…ub.com:jembi/openhim-core-js into TB-173-resolve-forever-processing-transactions
MatthewErispe
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If OpenHIM crashes with a request in-flight (so before the down stream service responds) this transaction will stay in 'Processing' forever and does not provide a true reflection of the transaction state.
So on startup it will find all transactions in that state and update them to failed. It uses mongoose's cursor functionality which returns a stream and so shouldn't interfere with the main application as it will only process once the stream receives data. It also properly respects node's event loop and so won't block it (i.e.: incoming requests still get processed normally).