Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace history syncing with RouterHistory #5825

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

thornbill
Copy link
Member

@thornbill thornbill commented Jul 24, 2024

Changes

  • Unifies the experimental and stable app routers (similar to the changes in Use lazy routes everywhere #5802)
  • Adds RouterHistory as an implementation of the History interface backed by the underlying react-router instance. This replaces the history syncing implementation that causes history actions to be invalid and/or duplicated (everything registers as a REPLACE).
  • Adds redirects for legacy #! url format

What needs testing?

  • General navigation throughout the app
  • Opening/closing dialogs
  • Redirects for legacy urls starting with #!

Issues
Related to #5656 (fixes the incorrect and duplicate history events that prevents us from reverting the caching behavior) (will require additional changes to fully fix)

@thornbill thornbill added bug Something isn't working needs testing This PR requires additional testing labels Jul 24, 2024
@thornbill thornbill added this to the v10.9.9 milestone Jul 24, 2024
Copy link

sonarcloud bot commented Jul 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
6 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@thornbill
Copy link
Member Author

Preview URL: https://44f001e6.jellyfin-web.pages.dev/

@nielsvanvelzen
Copy link
Member

Did a bunch of navigation, playing items, opening menus/overlays, going to dashboard and back. Both on the unstable demo and my stable server. Overall everything feels fine, found two issues that I could also reproduce in 10.9.8, so most likely not related to this PR.

  • When opening a dialog (e.g. "cast to" menu) and then close it, the browser things it can go forward. (also in 10.9.8)
  • Opening the "favorite" tab on the homepage does not allow to go back to the "home" tab with a back press. (also in 10.9.8)

@thornbill thornbill marked this pull request as ready for review July 25, 2024 20:41
@thornbill thornbill requested a review from a team as a code owner July 25, 2024 20:41
Copy link
Member

@grafixeyehero grafixeyehero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thornbill thornbill removed the needs testing This PR requires additional testing label Aug 1, 2024
@thornbill thornbill merged commit 7acdb66 into jellyfin:release-10.9.z Aug 1, 2024
9 checks passed
@thornbill thornbill deleted the router-v13 branch August 1, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants