Fix Up upNextDialog blocked by transparent video controls

[anthonym01]

On high display scaling, the controls sit over the up next dialog, i know its a sloppy change but i hope you wont mind :)

Changes
src\components\upnextdialog\upnextdialog.scss

Issues
Fix Up upNextDialog blocked by transparent video controls

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[dmitrylyzo]

UpNextDialog should only be displayed when the bottom OSD is hidden.
Could you post a screenshot of which element is overlapping?

[vivekkairi]

UpNextDialog should only be displayed when the bottom OSD is hidden. Could you post a screenshot of which element is overlapping?

The OSD is displayed above the UpNext component.

[dmitrylyzo]

The OSD is displayed above the UpNext component.

Then the bug is displaying OSD at the same time as UpNextDialog.

Hm, why does videoOsdBottom-hidden have opacity 0.8?

[vivekkairi]

The OSD is displayed above the UpNext component.

Then the bug is displaying OSD at the same time as UpNextDialog.

Hm, why does videoOsdBottom-hidden have opacity 0.8?

I added that 0.8 for displaying the overlap. The actual code shows opacity of 0 and has lower z-index to hide the OSD.

[dmitrylyzo]

The actual code shows opacity of 0 and has lower z-index to hide the OSD.

The hide class (display: none) is actually used to hide the OSD. With this class, the element becomes completely transparent to the user's actions.
It should be added after the hiding animation is complete:

jellyfin-web/src/controllers/playback/video/index.js

Line 334 in 003bc94

elem.classList.add('hide');

There was a bug where the wrong element was hidden due to duplicate views. But this was fixed in 10.8: #4561

Could you check if the hide class is actually not added to the OSD?

[dmitrylyzo]

I was able to reproduce the "missing hide class" in webOS 5 emulator with Ultrachromic skin. Disabling it fixes the problem.

[thornbill]

Underlying issue is fixed in #5653