-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix chapter marker re-rendering #5593
Fix chapter marker re-rendering #5593
Conversation
Quality Gate passedIssues Measures |
@@ -203,14 +203,14 @@ function setMarker(range, valueMarker, marker, valueProgress) { | |||
} | |||
|
|||
function updateMarkers(range, currentValue) { | |||
if (range.getMarkerInfo) { | |||
if (range.getMarkerInfo && !range.markerInfo) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't markerInfo
(as well as the slider itself) preserved when start playing the next video, so the markers won't be updated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my testing it was not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only get to the breakpoint once per refresh. So I assume they are preserved (because videoosd doesn't reload for the next item).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm yeah you are right... I'm not sure how it worked when I originally tested... #5601
Fix chapter marker re-rendering Original-merge: bd03c43 Merged-by: thornbill <[email protected]> Backported-by: Joshua M. Boniface <[email protected]>
Changes
markerInfo
is already populatedmaterial-icons
classIssues
I can't find one, but I saw the chapter markers flashing being reported somewhere...