automatically switch to LocalAddress when accessible

[kookxiang]

Changes

a server has two addresses: ManualAddress (via internet) + LocalAddress (local only).
when a server LocalAddress is accessible, it should not use ManualAddress.
it seems like this feature was disabled somehow, this PR just enable it

I'd test it on my server and it works well.

Issues

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[dmitrylyzo]

That's old: https://github.com/jellyfin/jellyfin-web/blame/f5c2a331b0f69c92202aa6c622e2885ed3e6e7ba/src/scripts/site.js#L199

I guess it currently works as you described, only in the standalone mode (or bundled apps): jellyfin/jellyfin-tizen#113 (comment)

After the change, UI will still be loaded from the remote (manual) address, right?

[kookxiang]

yes. all resources are loaded from ManualAddress.

so is it safe to turn on this feature by default? or should add option to it?

[thornbill]

I haven't looked at how this is implemented in the apiclient yet, but this may cause issues with docker installs where the local address can be the IP address of the container on the docker network.

[dmitrylyzo]

In theory, it will try 3 addresses: https://github.com/jellyfin/jellyfin-apiclient-javascript/blob/e8bd1b0e137068b3874ef35720453787e41aba60/src/connectionManager.js#L618-L652
The bundled app does this all the time, iirc

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.3% Duplication