fix(subtitle): fix subtitle position by updating libpgs to v0.8.0 #2487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mplemented cropping.
Cloudflare Pages deployment
|
|
Arcus92
changed the title
|
@Arcus92 Thank you for your PR, but this is not needed (unlike the jellyfin-web PR, where further changes were required). The @jellyfin/sdk update needs some changes in the code and that's why I haven't merged that PR rightaway! Thank you very much for keeping a track of Jellyfin Vue as well as Web! I highly appreciate it! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR updates libpgs-js to version v0.8.0:
Issues
Fixes jellyfin/jellyfin-web#6273
Related PRs