feat: Improve customization for subtitles #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves support for subtitle customization.
Creates new subtitle specific settings that enable: separate font and border color, background color and transparency.
Specifically modifies "subtitles" section of settings:
I have replaced previous color "subtitles.blackWhite" with separate "subtitles.white" and "subtitles.black" colors - the name no longer made sense. Rest of the colors were reused.
I have also included transparency "subtitles.0%" (0%, 25%, 50%, 75% and 100%)
Not sure about proper translations/mapping of settings text - let me know if more needs to be done.
The change to "color" settings is a breaking change. It will fallback to MPV default (white text with black border) until users set their new preferences.
However I think it is worth it. It would allow more customization in the future.
It is a start to fixing #284 The feature parity is not 100%. If it looks good I can add more features in the future.