Fix window switching monitor when exiting fullscreen #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwalton3
approved these changes
Aug 20, 2023
|
Since this change, opening the application on Hyprland made the window floating and fills the whole screen (with the top of the window behind waybar), instead of the default tiled mode. This change possibly breaks other tiling window managers as well, but I'm not sure what the best solution would be to fix this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #245
Fixed the issue for me. Tested it for a few months. Had this issue happen constantly before, and since applying these changes, it hasn't happened once.
Tested on Arch Linux, using the jellyfin-media-player AUR package modified to use this branch.
Based on the surrounding code, I don't know if these changes need to be limited to Linux, or if it will work fine for MacOS/Windows as well.