Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Never load PGS externally #4202

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Never load PGS externally #4202

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion app/src/main/java/org/jellyfin/androidtv/util/profile/ExoPlayerProfile.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,6 @@ class ExoPlayerProfile(
arrayOf(
Codec.Subtitle.SRT,
Codec.Subtitle.SUBRIP,
Codec.Subtitle.PGS,
Codec.Subtitle.PGSSUB,
Codec.Subtitle.DVBSUB,
Codec.Subtitle.VTT,
Expand All @@ -221,6 +220,14 @@ class ExoPlayerProfile(
add(subtitleProfile(codec, SubtitleDeliveryMethod.External))
}

// Rendering supported, but needs to be embedded
arrayOf(
Codec.Subtitle.PGS,
).forEach { codec ->
add(subtitleProfile(codec, SubtitleDeliveryMethod.Embed))
add(subtitleProfile(codec, SubtitleDeliveryMethod.Hls))
}

// Require baking
arrayOf(
Codec.Subtitle.ASS,
Expand Down
Loading