Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip external subtitle streams when resolving embedded subtitle stream by index #4192

Closed
wants to merge 1 commit into from
Closed

Skip external subtitle streams when resolving embedded subtitle stream by index #4192

wants to merge 1 commit into from

Conversation

nielsvanvelzen
Copy link
Member

I haven't reproduced the issue yet and thus have no idea if this fix works. Putting it up for testing.

Changes

  • Skip external subtitle streams when resolving embedded subtitle stream by index

Issues

Fixes #4182
Fixes #4183

@nielsvanvelzen nielsvanvelzen added the bug Something isn't working label Nov 10, 2024
@nielsvanvelzen nielsvanvelzen added this to the v0.18.0 milestone Nov 10, 2024
@nielsvanvelzen nielsvanvelzen mentioned this pull request Nov 10, 2024
Closed
@The-Randalorian
Copy link
Contributor

The-Randalorian commented Nov 11, 2024 •
edited
Loading

Confirmed fixes #4182 Does not fix. The new app didn't use the old settings, so the bitrate limit wasn't applied and content was direct playing, not transcoding. PGS still not working while transcoding.

I don't have media to test #4183

Edit: Correction after further testing.

@nielsvanvelzen nielsvanvelzen deleted the maybe-fix-embedded-subs branch November 11, 2024 21:14
@nielsvanvelzen nielsvanvelzen removed this from the v0.18.0 milestone Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Selecting embedded subtitle track leads to different track being displayed PGS Subtitles Not Being Used
2 participants
@nielsvanvelzen @The-Randalorian