Add experimental Trickplay implementation #4172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsvanvelzen
added
enhancement
nielsvanvelzen
force-pushed
the
trickplay
branch
from
11edd21 to
a491e97
Compare
|
As a side-note; it is possible that the TrickPlay images don't show up when starting playback from specific screens. the app must request the TrickPlay metadata when retrieving items and I might have forgotten to add that to a few places. If you find one of these spots; please open an issue to let me know and I'll fix it. |
crobibero
approved these changes
Nov 5, 2024
nielsvanvelzen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an implementation of TrickPlay images using the thumbnail support in the Leanback PlaybackSeekDataProvider. We have no control over the UI and I'm not a fan of how it looks, therefor this feature is disabled by default. Enabling the feature can be done in the developer settings (it is a public developer option, available in release builds).
Changes
Screenshots
Issues
Fixes #3585