Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync custom controls with built-in controls in leanback overlay #4118

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

nielsvanvelzen
Copy link
Member

So we have an unmaintained library that implements like 60% of the player user interface, but on top of that we have a bunch of hacky code. Simply said, the player UI has a bottom-region with the buttons etc. which is implemented by leanback and a top-region that is implemented by us.

Whenever the controls are shown or hidden these would never be in sync, sometimes the title would randomly appear during seeking etc. This is super annoying and especially with the "ask to skip" media segment action it was just painful.

So I synced them. and probably introduced new bugs

Changes

  • Show "topPanel" by default, just like the leanback overlay
  • Hide/show "topPanel" when leanback overlay is shown/hidden
  • Added checks to "topPanel" to not show when already shown or hide when already hidden, this caused the animations to replay which looked weird and stupid
  • Increased headache by 40%

Issues

@nielsvanvelzen nielsvanvelzen added the bug Something isn't working label Oct 29, 2024
@nielsvanvelzen nielsvanvelzen added this to the v0.18.0 milestone Oct 29, 2024
@nielsvanvelzen nielsvanvelzen merged commit e7738c7 into jellyfin:master Oct 29, 2024
5 checks passed
@nielsvanvelzen nielsvanvelzen deleted the lean-back-crap-title branch October 29, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants