Sync custom controls with built-in controls in leanback overlay #4118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we have an unmaintained library that implements like 60% of the player user interface, but on top of that we have a bunch of hacky code. Simply said, the player UI has a bottom-region with the buttons etc. which is implemented by leanback and a top-region that is implemented by us.
Whenever the controls are shown or hidden these would never be in sync, sometimes the title would randomly appear during seeking etc. This is super annoying and especially with the "ask to skip" media segment action it was just painful.
So I synced them. and probably introduced new bugs
Changes
Issues