Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't skip media segments shorter than 1 second #4064

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Don't skip media segments shorter than 1 second #4064

merged 1 commit into from
Oct 9, 2024

Conversation

nielsvanvelzen
Copy link
Member

I did document it in the MediaSegmentAction enum but I forgot the implementation :-)

Changes

  • Don't return the SKIP action from MediaSegmentRepository.getMediaSegmentAction when duration is <1second
  • Add extension getters for start/end and duration of a segment

Issues

@nielsvanvelzen nielsvanvelzen added the enhancement New feature or request label Oct 9, 2024
@nielsvanvelzen nielsvanvelzen added this to the v0.18.0 milestone Oct 9, 2024
@nielsvanvelzen nielsvanvelzen changed the title Don't skip segments shorter than 1 second Don't skip media segments shorter than 1 second Oct 9, 2024
@nielsvanvelzen nielsvanvelzen merged commit 961c858 into jellyfin:master Oct 9, 2024
5 checks passed
@nielsvanvelzen nielsvanvelzen deleted the skip-skip-action branch October 9, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crobibero crobibero crobibero approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.18.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsvanvelzen @crobibero