Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #3811

Merged
merged 1 commit into from
Aug 3, 2024
Merged

Fix typos #3811

merged 1 commit into from
Aug 3, 2024

Conversation

starsep
Copy link
Contributor

@starsep starsep commented Jul 25, 2024

Changes

I fixed typos I was able to spot/find using typos CLI/Android Studio's Typo inspection.
One file was renamed. I hope it won't cause merge conflicts :)

@starsep starsep requested a review from nielsvanvelzen as a code owner July 25, 2024 21:29
@@ -95,7 +95,7 @@

val goodRecommendations = mutableListOf<RecommendedServerInfo>()
val badRecommendations = mutableListOf<RecommendedServerInfo>()
val greatRecommendaton = jellyfin.discovery.getRecommendedServers(addressCandidates).firstOrNull { recommendedServer ->
val greatRecommendation = jellyfin.discovery.getRecommendedServers(addressCandidates).firstOrNull { recommendedServer ->

Check warning

Code scanning / detekt

Line detected, which is longer than the defined maximum line length in the code style. Warning

Line detected, which is longer than the defined maximum line length in the code style.
@@ -158,7 +158,7 @@
}
}

public CharSequence gettitle() {
public CharSequence getTitle() {

Check notice

Code scanning / Android Lint

Unknown nullness Note

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations
@@ -204,7 +204,7 @@
}

// this makes focus movements more predictable for the grid view
public static void setFocusParms(LinearLayout currentRow, LinearLayout otherRow, boolean up) {
public static void setFocusParams(LinearLayout currentRow, LinearLayout otherRow, boolean up) {

Check notice

Code scanning / Android Lint

Unknown nullness Note

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations
@@ -204,7 +204,7 @@
}

// this makes focus movements more predictable for the grid view
public static void setFocusParms(LinearLayout currentRow, LinearLayout otherRow, boolean up) {
public static void setFocusParams(LinearLayout currentRow, LinearLayout otherRow, boolean up) {

Check notice

Code scanning / Android Lint

Unknown nullness Note

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations
@nielsvanvelzen nielsvanvelzen merged commit 8230479 into jellyfin:master Aug 3, 2024
5 checks passed
@nielsvanvelzen nielsvanvelzen added this to the v0.18.0 milestone Aug 3, 2024
@nielsvanvelzen nielsvanvelzen added the refactor Improvements to code realiability, readability and quality label Aug 3, 2024
@starsep starsep deleted the typos branch August 3, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Improvements to code realiability, readability and quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants