Fix loading issues with embedded SUBRIP subtitles while using Exoplayer #2743
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, embedded SRT/SUBRIP subtitles can take a long time to load because it requires the server to use ffmpeg to extract the embedded subtitles out of the video stream in order to return a JSON file of the subtitles so they can be used by the custom overlay. A longer explanation is here. For large videos (such as 4K), this can take minutes to load a single subtitle. After these fixes, they load near instantaneously by Exoplayer.
Changes
Issues
Fixes #145
(Note: I'm not a Java developer and haven't contributed to this project before, so any and all suggestions for how to implement this better are welcomed!)