Don't ignore detekt failures anymore #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsvanvelzen
requested changes
Dec 21, 2022
Maxr1998
force-pushed
the
stop-ignoring-detekt
branch
2 times, most recently
from
a2fd97f to
aa843f5
Compare
|
Looking at the logs, the report is still written, so it should be fine. I also split the lint and detekt jobs so that they don't influence each other. |
|
I think that's because there's only warnings right now and no errors. |
Maxr1998
force-pushed
the
stop-ignoring-detekt
branch
2 times, most recently
from
2eda862 to
b273927
Compare
nielsvanvelzen
approved these changes
Dec 24, 2022
Maxr1998
added
ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.