-
-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite connection screen in Jetpack Compose #800
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
android:id="@+id/compose_view" | ||
android:layout_width="match_parent" | ||
android:layout_height="match_parent" | ||
android:background="@color/theme_background" /> |
Check warning
Code scanning / Android Lint
Overdraw: Painting regions more than once
Possible overdraw: Root element paints background @color/theme_background with a theme that also paints a background (inferred theme is @style/AppTheme)
Maxr1998
force-pushed
the
connect-fragment-compose
branch
3 times, most recently
from
September 21, 2022 16:29
6dbe848
to
5ecdc47
Compare
nielsvanvelzen
requested changes
Sep 21, 2022
Maxr1998
force-pushed
the
connect-fragment-compose
branch
from
September 21, 2022 18:04
5ecdc47
to
30251b7
Compare
Maxr1998
force-pushed
the
connect-fragment-compose
branch
from
September 21, 2022 18:12
30251b7
to
29ef552
Compare
Maxr1998
force-pushed
the
connect-fragment-compose
branch
from
September 21, 2022 19:38
29ef552
to
be71279
Compare
nielsvanvelzen
approved these changes
Sep 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yolo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Already somewhat ready for review, but I need to look at it another time tomorrow and might want to do some more testing.