Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update android.plugin to v8 (major) #1101

Merged
merged 3 commits into from
Jun 10, 2023
Merged

Update android.plugin to v8 (major) #1101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a2897a
Update android.plugin to v8
renovate[bot] Jun 10, 2023
a1398e8
Migrate to AGP v8
Maxr1998 Jun 10, 2023
5697a83
Remove redundant suppressions
Maxr1998 Jun 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ android {

@Suppress("UnstableApiUsage")
buildFeatures {
buildConfig = true
viewBinding = true
compose = true
}
Expand Down Expand Up @@ -156,9 +157,7 @@ dependencies {
exclude("com.google.android.gms", "play-services-cronet")
}
implementation(libs.jellyfin.exoplayer.ffmpegextension)
@Suppress("UnstableApiUsage")
proprietaryImplementation(libs.exoplayer.cast)
@Suppress("UnstableApiUsage")
proprietaryImplementation(libs.bundles.playservices)

// Room
Expand Down
3 changes: 2 additions & 1 deletion app/src/main/java/org/jellyfin/mobile/player/ui/PlayerFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ import org.jellyfin.mobile.utils.extensions.keepScreenOn
import org.jellyfin.mobile.utils.toast
import org.jellyfin.sdk.model.api.MediaStream
import org.koin.android.ext.android.inject
import com.google.android.exoplayer2.ui.R as ExoplayerR

class PlayerFragment : Fragment() {
private val appPreferences: AppPreferences by inject()
Expand Down Expand Up @@ -329,7 +330,7 @@ class PlayerFragment : Fragment() {
}
}
setAspectRatio(aspectRational)
val contentFrame: View = playerView.findViewById(R.id.exo_content_frame)
val contentFrame: View = playerView.findViewById(ExoplayerR.id.exo_content_frame)
val contentRect = with(contentFrame) {
val (x, y) = intArrayOf(0, 0).also(::getLocationInWindow)
Rect(x, y, x + width, y + height)
Expand Down
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[versions]
# Plugins
android-plugin = "7.4.2"
android-plugin = "8.0.2"
kotlin = "1.7.20"
kotlin-ksp = "1.7.20-1.0.8"
detekt = "1.22.0"
Expand Down