Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Admin Dashboard - User Permissions #1313

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

JPKribs
Copy link
Member

@JPKribs JPKribs commented Nov 12, 2024

Summary

Creates a Permissions view in the userDetailsView to allow for permission editing.

At this time, I am still working out the organization for the buttons I have. The working views are:

- Permissions

  • Disabled Toggle
  • Administrator Toggle
  • External Access / Bitrate
  • SyncPlay Access
  • Remote Control of Other Devices
  • Max Sessions / Failed Logins
  • Other Permissions

- Profile

  • Username
  • Profile Picture Editing

- Parental Controls

  • Max Ratings
  • Access Schedule
  • Blocked Items

- Media Access

  • Accessible Folders

- Media Deletion

  • Deletable Folders

- Live TV

  • Accessible Channels
  • Live TV Recording/Permissions

This PR will only cover the items that end up in the more generic Permissions view as a catch all for items that don't have a better home.

Screenshots

Screenshot 2024-11-13 at 16 18 01

@JPKribs JPKribs marked this pull request as ready for review November 13, 2024 23:13
@JPKribs JPKribs changed the title [WIP] [iOS] Admin Dashboard - User Permissions [iOS] Admin Dashboard - User Permissions Nov 13, 2024
Copy link
Member

@LePips LePips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having just done a quick skim, let's remove the Allow prefix from each string, as the toggle should be enough to understand the permission setting.

@JPKribs
Copy link
Member Author

JPKribs commented Nov 21, 2024

Having just done a quick skim, let's remove the Allow prefix from each string, as the toggle should be enough to understand the permission setting.

Sounds good! These have been updated.

@JPKribs JPKribs added enhancement New feature or request and removed enhancement New feature or request labels Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants