Fix: notify expiration only if the latest expire time is changed when getItem or SetWithTTL #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… getItem or SetWithTTL
ReneKroon
reviewed
Oct 15, 2021
|
|
||
| item.touch() | ||
| cache.priorityQueue.update(item) | ||
| if item.ttl == 0 { |
There was a problem hiding this comment.
a bit implicit from line 90 (implying cache.ttl > 0 when you get here), but ok
There was a problem hiding this comment.
if cache.ttl = 0, item.ttl will also remain 0. This is what we want, but with less code.
|
By the way, can we get a release version later at your convenience? I need recent commits for my project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the latest expire time is changed, no need to notify expiration.
Benchmark Result
According the benchmark result, it has 2~3 times performance improvement