Skip to content

Commit

Permalink
fix double insertion into expiration queue
Browse files Browse the repository at this point in the history
Signed-off-by: Vladislav Yarmak <[email protected]>
  • Loading branch information
Snawoot authored and swithek committed Jun 11, 2024
1 parent 9ca4fc0 commit 62c3733
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
12 changes: 6 additions & 6 deletions cache.go
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ func (c *Cache[K, V]) set(key K, value V, ttl time.Duration) *Item[K, V] {
ttl = c.options.ttl
}

elem := c.get(key, false)
elem := c.get(key, false, true)
if elem != nil {
// update/overwrite an existing item
item := elem.Value.(*Item[K, V])
Expand Down Expand Up @@ -176,14 +176,14 @@ func (c *Cache[K, V]) set(key K, value V, ttl time.Duration) *Item[K, V] {
// It returns nil if the item is not found or is expired.
// Not safe for concurrent use by multiple goroutines without additional
// locking.
func (c *Cache[K, V]) get(key K, touch bool) *list.Element {
func (c *Cache[K, V]) get(key K, touch bool, includeExpired bool) *list.Element {
elem := c.items.values[key]
if elem == nil {
return nil
}

item := elem.Value.(*Item[K, V])
if item.isExpiredUnsafe() {
if !includeExpired && item.isExpiredUnsafe() {
return nil
}

Expand Down Expand Up @@ -218,7 +218,7 @@ func (c *Cache[K, V]) getWithOpts(key K, lockAndLoad bool, opts ...Option[K, V])
c.items.mu.Lock()
}

elem := c.get(key, !getOpts.disableTouchOnHit)
elem := c.get(key, !getOpts.disableTouchOnHit, false)

if lockAndLoad {
c.items.mu.Unlock()
Expand Down Expand Up @@ -436,7 +436,7 @@ func (c *Cache[K, V]) DeleteExpired() {
// If the item is not found, the method is no-op.
func (c *Cache[K, V]) Touch(key K) {
c.items.mu.Lock()
c.get(key, true)
c.get(key, true, false)
c.items.mu.Unlock()
}

Expand Down Expand Up @@ -469,7 +469,7 @@ func (c *Cache[K, V]) Items() map[K]*Item[K, V] {

items := make(map[K]*Item[K, V], len(c.items.values))
for k := range c.items.values {
item := c.get(k, false)
item := c.get(k, false, false)
if item != nil {
items[k] = item.Value.(*Item[K, V])
}
Expand Down
2 changes: 1 addition & 1 deletion cache_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@ func Test_Cache_get(t *testing.T) {
oldItem.ttl = 0
}

elem := cache.get(c.Key, c.Touch)
elem := cache.get(c.Key, c.Touch, false)

if c.Key == notFoundKey {
assert.Nil(t, elem)
Expand Down

0 comments on commit 62c3733

Please sign in to comment.