-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for excerpts on homepage #90
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool stuff, I was definitely confused why my post excerpts weren't working when I first tried it. Didn't think the theme was missing support for it.
Personally, I would remove the horizontal divider and even out the vertical spacing above and below the post titles. I think it would look cleaner.
README.md
Outdated
To display post-excerpts on the Home Page, simply add the following to your `_config.yml`: | ||
|
||
```yaml | ||
show_excerpts: enabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should excerpts just be enabled in all cases? Enabled by default? Why do we need to make this an option?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer excerpts to be enabled by default. But made it an option because I didn't want Minima to suddenly change how existing sites would look.. We can make it enabled by default in the next major release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be true/false
if it's a boolean value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true/false
seems more appropriate 👍
@benbalter would it be wiser to move the switch to under
|
Not strongly opinionated. If we don't namespace it, we can create a default practice/pattern for other themes. |
I agree. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a big fan of all these hr, I'd rather discuss about styles in a separate PR
/cc @DirtyF revised based on your previous review.. |
_layouts/home.html
Outdated
</ul> | ||
|
||
<p class="rss-subscribe">subscribe <a href="{{ "/feed.xml" | relative_url }}">via RSS</a></p> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DirtyF please address the alignment and extra whitespace on this template before you cut a new version..
I miss something like "More" or "Continue reading →" link at and of excerpt. If excerpt is long, as you can see for example on https://hackaday.com/blog/ , someone can think that this is whole small article and don't read full one. |
Add support for displaying excerpts on the Home Page.
show_excerpts = enabled
to your _config.yml to enable displaying excerpts on the home page.<hr>
(horizontal rule) to provide a visual separation between list items.Preview of Home Page with excerpts enabled: