Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for excerpts on homepage #90

Merged
merged 8 commits into from
Jan 27, 2018
Merged

Conversation

ashmaroli
Copy link
Member

@ashmaroli ashmaroli commented Dec 5, 2016

Add support for displaying excerpts on the Home Page.

  • add show_excerpts = enabled to your _config.yml to enable displaying excerpts on the home page.
  • Enabling excerpts adds an underline to the heading and adds an invisible <hr> (horizontal rule) to provide a visual separation between list items.

Preview of Home Page with excerpts enabled:

excerpts

Copy link

@joeydong joeydong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff, I was definitely confused why my post excerpts weren't working when I first tried it. Didn't think the theme was missing support for it.

Personally, I would remove the horizontal divider and even out the vertical spacing above and below the post titles. I think it would look cleaner.

README.md Outdated
To display post-excerpts on the Home Page, simply add the following to your `_config.yml`:

```yaml
show_excerpts: enabled
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should excerpts just be enabled in all cases? Enabled by default? Why do we need to make this an option?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer excerpts to be enabled by default. But made it an option because I didn't want Minima to suddenly change how existing sites would look.. We can make it enabled by default in the next major release.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks makes sense.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be true/false if it's a boolean value?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true/false seems more appropriate 👍

@ashmaroli
Copy link
Member Author

@benbalter would it be wiser to move the switch to under minima namespace? as in

{% if site.minima.show_excerpts %}
[...]

@benbalter
Copy link
Contributor

would it be wiser to move the switch to under minima namespace?

Not strongly opinionated. If we don't namespace it, we can create a default practice/pattern for other themes.

@ashmaroli
Copy link
Member Author

If we don't namespace it, we can create a default practice/pattern for other themes.

I agree. 👍
Ready to be reviewed..

@DirtyF DirtyF requested a review from jglovier April 8, 2017 11:34
Copy link
Member

@DirtyF DirtyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big fan of all these hr, I'd rather discuss about styles in a separate PR

@ashmaroli
Copy link
Member Author

Revised preview

minima-excerpts

@ashmaroli
Copy link
Member Author

/cc @DirtyF revised based on your previous review..

@DirtyF DirtyF requested a review from a team October 24, 2017 04:25
@DirtyF DirtyF merged commit 3960a68 into jekyll:master Jan 27, 2018
</ul>

<p class="rss-subscribe">subscribe <a href="{{ "/feed.xml" | relative_url }}">via RSS</a></p>

Copy link
Member Author

@ashmaroli ashmaroli Jan 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DirtyF please address the alignment and extra whitespace on this template before you cut a new version..

@jekyllbot jekyllbot mentioned this pull request Jan 27, 2018
@ashmaroli ashmaroli deleted the excerpt branch January 29, 2018 17:44
@ziutek
Copy link

ziutek commented Mar 26, 2018

I miss something like "More" or "Continue reading →" link at and of excerpt. If excerpt is long, as you can see for example on https://hackaday.com/blog/ , someone can think that this is whole small article and don't read full one.

@jekyll jekyll locked and limited conversation to collaborators Apr 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants