Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify Rakefile to watch assets folder as well #81

Closed
wants to merge 1 commit into from

Conversation

ashmaroli
Copy link
Member

This pull modifies the Rakefile to have the assets dir watched during development

/cc @jekyll/minima

@benbalter
Copy link
Contributor

Dumb question... why can't we just use jekyll serve --watch?

@ashmaroli
Copy link
Member Author

why can't we just use jekyll serve --watch?

@benbalter, because:

  • --watch is enabled by default for the source_dir (/example in this case) and not the theme_gem (minima) files.
  • we watch minima files during development by having the Rakefile define what to watch.
    Hence bundle exec rake preview uses current minima-branch instead of an installed version.

@benbalter
Copy link
Contributor

Can we simplify that by collapsing the example files into the root?

@ashmaroli
Copy link
Member Author

Can we simplify that by collapsing the example files into the root?

I'm against that because I'd like the root to only show directories actually relevant to the theme. We can easily test n showcase Jekyll reading extra-source_dir directories n files. Hope that's clear..

But if the other members on @jekyll/minima are fine with the move, I wont mind..

@DirtyF
Copy link
Member

DirtyF commented Nov 15, 2016

@benbalter isn't what we've done in #76 ?

@benbalter
Copy link
Contributor

I'd rather go with #76 here. Less code is more better. Thanks @ashmaroli, as always for the PR and sorry for the slow response.

@benbalter benbalter closed this Apr 7, 2017
@jekyll jekyll locked and limited conversation to collaborators Apr 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants