Revert social_sites hash #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DirtyF
approved these changes
Jan 27, 2018
DirtyF
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing a
social_siteshash was an unintentional change I committed and pushed but wasn't caught during the review. The consequence is that users who upgrade will silently have missing social links when their existing_config.ymlis usingtwitter_usernameorgithub_username. Only the rss feed will remain.I apologize for this defect. It was a local experiment that was intended to be made on an experimental local git branch but was accidentally committed during code review comments and was subsequently never caught in the review.
Hopefully, this change can be reverted as a bug fix release 2.2.1 posthaste.