Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test against Ruby 2.5 #260

Merged
merged 2 commits into from
Jan 5, 2018
Merged

Test against Ruby 2.5 #260

merged 2 commits into from
Jan 5, 2018

Conversation

jekyllbot
Copy link
Contributor

PR automatically created for @DirtyF.

Test against Ruby 2.5

benbalter
benbalter approved these changes Jan 3, 2018
View reviewed changes
Copy link
Collaborator

@benbalter benbalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 if/when tests pass!

@pathawks
Copy link
Member

pathawks commented Jan 4, 2018

Rubocop is complaining

@DirtyF
Copy link
Member

DirtyF commented Jan 4, 2018

@pathawks looks like jekyll 3.6.2 rubocop's config is the culprit here

@ashmaroli
Copy link
Member

The solution here is to lock Rubocop to the version supported by Jekyll..
There's bound to be conflicts when we inherit .rubocop.yml from jekyll gem (uses Rubocop 0.51.0 max) yet the plugin uses a future version of Rubocop for development (Rubocop 0.52.1)

@DirtyF
Copy link
Member

DirtyF commented Jan 5, 2018

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit d69e08c into master Jan 5, 2018
@jekyllbot jekyllbot deleted the pull/ruby-2.5 branch January 5, 2018 20:03
jekyllbot added a commit that referenced this pull request Jan 5, 2018
@jekyllbot
Update history to reflect merge of #260 [ci skip]
47200c4
@jekyll jekyll locked and limited conversation to collaborators May 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@benbalter benbalter benbalter approved these changes

Assignees
No one assigned
Labels
fix frozen-due-to-age internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jekyllbot @pathawks @DirtyF @ashmaroli @benbalter