-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): require Ruby >=2.4.0 #307
Conversation
From what I recall, we have not started enforcing Ruby 2.4 in core plugin's gemspec if the library code doesn't use any Ruby 2.4+ specific syntax.. |
It's more about following Ruby release cycle, and require a maintained Ruby release. You're right the current codebase style is OK even we were to target Ruby 2.7, but we didn't bother looking if we could use the latest Ruby additions. |
I'm still of the opinion that this change is not necessary — there's no explicit need to use this plugin with Ruby 2.4 and above. But there's already an approval, so perhaps I'm not seeing the value.. |
@jekyll: merge +minor |
Align with other core plugins that already require 2.4
Ruby 2.4 is now EOL.