Dont forget about categories #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the frontmatter for posts can use `category` OR `categories` as per [documentation from jekyllrb.com](https://jekyllrb.com/docs/frontmatter/#predefined-variables-for-posts), it would make sense to also allow for categories to populate the XML data. This change does not appear to be of a breaking type, as we already had the potential of multiple category tags from the combined use of `category` and `tags`. This just opens up the potential for even more `category` tags to be in the feed.xml thats output
DirtyF
approved these changes
Sep 6, 2018
|
As long as we follow the spec, I'm 👍
https://cyber.harvard.edu/rss/rss.html#ltcategorygtSubelementOfLtitemgt |
|
@jekyll: merge +minor |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the frontmatter for posts can use
categoryORcategoriesas per documentation from jekyllrb.com, it would make sense to also allow for categories to populate the XML data.This change does not appear to be of a breaking type, as we already had the potential of multiple category tags from the combined use of
categoryandtags. This just opens up the potential for even morecategorytags to be in the feed.xml thats output