Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for image element #14

Closed
XhmikosR opened this issue May 12, 2015 · 12 comments · Fixed by #104
Closed

Add support for image element #14

XhmikosR opened this issue May 12, 2015 · 12 comments · Fixed by #104

Comments

@XhmikosR
Copy link
Contributor

@pathawks
Copy link
Member

Yes, love it. But we would need to make sure that such an image actually exists in the site first.

Is there a way to do this without just config 🎄?

Also, perhaps #2 should be sorted out first, before diving too deep into these features?

@XhmikosR
Copy link
Contributor Author

I don't think you can do that since the URL is the remote one. So one might upload it at a later time. Also note that this only seems to work with IE and Firefox that I have tested; Chrome doesn't show this without an extension.

Since this is an optional element, I'd say whoever is using it knows what to do with it :P

What I think we could have is a check for the dimensions since the specs have a limit there.

@pathawks
Copy link
Member

I don't think you can do that since the URL is the remote one.

I just mean we shouldn't start including an <image> in all feeds; there would need to be either a setting or something to specify the image URL, or a check for a specific file to be used as the image if it existed.

@XhmikosR
Copy link
Contributor Author

Oh, that. Sure.

But IMO all image sub-elements should be mandatory so we should check for all of them.

@benbalter benbalter modified the milestone: Someday (TM) May 18, 2015
@pathawks
Copy link
Member

In Atom, this is called <logo>, and there is also <icon> for favicon type images.

(Just leaving notes for myself.)

@ElMassimo
Copy link

Any updates on this one now that #2 is resolved?

@XhmikosR
Copy link
Contributor Author

That is a post image though. Not a site wide one. Does atom support image
in root?
On Mar 23, 2016 00:18, "jekyllbot" [email protected] wrote:

Closed #14 #14 via #104
#104.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#14 (comment)

@pathawks
Copy link
Member

@XhmikosR Do you know of a feed reader that displays a per feed image? How would this be used?

@XhmikosR
Copy link
Contributor Author

I know Firefox shows the image to the right. But that was with RSS. Not sure if atom supports it. The original request was from when this repo was RSS.

@pathawks
Copy link
Member

FWIW, WordPress adds a square 32px icon to Atom feeds.

I am not sure what this would be used for and I can't think of any way to add support for it without adding a config option (:christmas_tree:), so I am not enthusiastic about the idea.

@XhmikosR
Copy link
Contributor Author

A config option will be needed that for sure.

I just feel an image makes things more official in a feed. It's the only thing I miss from my old RSS custom solution I was using.

@inetbiz
Copy link

inetbiz commented Mar 30, 2019

Is this implemented yet?

@jekyll jekyll locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants