-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for image
element
#14
Comments
Yes, love it. But we would need to make sure that such an image actually exists in the site first. Is there a way to do this without just config 🎄? Also, perhaps #2 should be sorted out first, before diving too deep into these features? |
I don't think you can do that since the URL is the remote one. So one might upload it at a later time. Also note that this only seems to work with IE and Firefox that I have tested; Chrome doesn't show this without an extension. Since this is an optional element, I'd say whoever is using it knows what to do with it :P What I think we could have is a check for the dimensions since the specs have a limit there. |
I just mean we shouldn't start including an |
Oh, that. Sure. But IMO all image sub-elements should be mandatory so we should check for all of them. |
In Atom, this is called (Just leaving notes for myself.) |
Any updates on this one now that #2 is resolved? |
That is a post image though. Not a site wide one. Does atom support image
|
@XhmikosR Do you know of a feed reader that displays a per feed image? How would this be used? |
I know Firefox shows the image to the right. But that was with RSS. Not sure if atom supports it. The original request was from when this repo was RSS. |
FWIW, WordPress adds a square 32px icon to Atom feeds. I am not sure what this would be used for and I can't think of any way to add support for it without adding a config option (:christmas_tree:), so I am not enthusiastic about the idea. |
A config option will be needed that for sure. I just feel an image makes things more official in a feed. It's the only thing I miss from my old RSS custom solution I was using. |
Is this implemented yet? |
Example: https://github.com/mpc-hc/mpc-hc.org/blob/master/source/rss.xml#L22-L29
https://validator.w3.org/feed/docs/rss2.html#optionalChannelElements
The text was updated successfully, but these errors were encountered: