Windows tests #153
Merged
Windows tests #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome 👍🏻 |
|
Got tests passing. For some reason Appveyor doesn't like rubocop, which I disabled, since it'll run on Travis anyways. Going to merge, since this fixes Windows support, but not going to make this a required test, as from my experience, Appveyor can sometimes be flaky, and while it can be informative, I don't want it to necessarily block things. To note, the setup is similar to travis, in that it uses |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests adds Appveyor Windows tests, and fixes a bug whereby collections, including posts, would not work on Windows due to improper path sanitization.