Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jekyll baseurl not applied / Not works in subfolder (relevant for especially for reverse proxy in subfolder) #471

Closed
gsantner opened this issue Jul 29, 2018 · 14 comments · May be fixed by #487
Labels

Comments

@gsantner
Copy link

gsantner commented Jul 29, 2018

Description:

I have set baseurl: /wiki in _config.yml and expected to get admin available on /wiki/admin/, but it doesn't work. Jekyll-Admin doesn't respect the setted baseurl.

Especially when serving through reverse proxy this is bad, because everything in Jekyll does use baseurl, but not jekyll-admin.

Tell us a bit about yourself:

  • Version of JekyllAdmin I'm using 0.8.1
  • Version of Jekyll I'm using 3.83
  • Operating System deb9

Steps to reproduce:

Set baseurl: /something and jekyll-admin listens at wrong location - /admin instead of /something/admin.

I expected the following:

Listening at /something/admin.

@kwalski
Copy link

kwalski commented Sep 12, 2018

I have the same issue. jekyll-admin disregards baseurl specified like jekyle serve --baseurl /example

@jekyllbot
Copy link

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

@gsantner
Copy link
Author

gsantner commented Nov 27, 2018

Still the case, responses from users are there, but none from jekyll devs.

@mertkahyaoglu
Copy link
Member

@gsantner Sorry for the hassle. Unfortunately this repo is not actively maintained. I will take a look at this when I get a chance!

@gsantner
Copy link
Author

@mertkahyaoglu
Oh, sorry too. Did look for maintainence notice but there was none at README, should have checked commit history :D.
Thanks for any work here, regardless if fixed

lexoyo added a commit to lexoyo/jekyll-admin that referenced this issue Apr 15, 2019
lexoyo added a commit to lexoyo/jekyll-admin that referenced this issue Apr 15, 2019
@lexoyo
Copy link
Collaborator

lexoyo commented Apr 15, 2019

Hello
Here is a first attempt to fix this issue
Feel free to test and comment, details are in the PR

@lexoyo
Copy link
Collaborator

lexoyo commented Apr 23, 2019

Is someone still interested in this? @gsantner @kwalski @mertkahyaoglu

@kwalski
Copy link

kwalski commented Apr 23, 2019

I would love this fix

@lexoyo
Copy link
Collaborator

lexoyo commented Apr 23, 2019

ok thx, I was not sure anymore :)
if you know how to test it that would help, before it is released
otherwise, tests will be for after I release it

@ashmaroli
Copy link
Member

if you know how to test it that would help, before it is released

Going through existing tests may provide an insight.
More info at: https://jekyll.github.io/jekyll-admin/development/

@lexoyo
Copy link
Collaborator

lexoyo commented Apr 23, 2019

All unit tests pass, I was thinking real life tests.

Only the fonts problem remain so I think it would be useful at this stage

@gsantner gsantner changed the title jekyll baseurl not counted in Jekyll baseurl not applied / Not works in subfolder (relevant for especially for reverse proxy in subfolder) Aug 1, 2019
@gsantner
Copy link
Author

gsantner commented Aug 1, 2019

@mertkahyaoglu
Is there a chance that @lexoyo 's PR at #471 gets merged? It's still impossible to serve as /wiki/ and edit via /wiki/admin/.

@lexoyo
Copy link
Collaborator

lexoyo commented Aug 1, 2019

Thx for your support @gsantner
Did you test it? Did it work as expected?

Please do not merge yet, there is still a problem with fonts, which I'll address if someone has tested the rest and it works as expected

lexoyo added a commit to lexoyo/jekyll-admin that referenced this issue Aug 13, 2019
@gsantner
Copy link
Author

gsantner commented May 2, 2020

Hey, I don't use jekyll-admin anymore, and never really have actively. I suggest actual users to try it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants