(Jellyfin) Allow multiple sessions from the same user with different instances #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow multiple sessions from the same user with different instances. Instead of sending a hard-coded string, send a randomly generated string `deviceId`, which already exists and is created for each new installation.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Allow multiple sessions from a single user with different instances of the same client. Although it's said that you cannot have multiple users signed in to the client with the same
deviceId, this limitation has already been removed here.Migrate from deprecated api auth methods. Additionally, send more information, as the official web client does, which will, for example, allow Feishin to signal its version immediately after an update, not only after a re-login.
Issues
Fixes #644, maybe fixes #653