Replace hardcoded Jellyfin authentication DeviceId to include hostname #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
It may also be worth including the username as well as hostname. Can submit an updated version if needed. |
|
This is good fix This exact issue presents itself on my own jellyfin server |
|
@LilyRose2798 Including username would be nice, especially if duplicate device ids affect existing sessions. |
LilyRose2798
force-pushed
the
fix-jellyfin-deviceid
branch
from
633a17f to
1a948ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug preventing two separate users on the same Jellyfin instance from being logged in simultaneously due to conflicting DeviceIds. See here for information on DeviceIds. If two clients try to authenticate using the same device id then the other will have their session revoked.