Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Electron to newer version, e.g. v29 #643

Closed
onny opened this issue Jun 12, 2024 · 2 comments
Closed

Bump Electron to newer version, e.g. v29 #643

onny opened this issue Jun 12, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@onny
Copy link

onny commented Jun 12, 2024

Expected Behavior

Updating electron in package.json to >= v29

Current Behavior

Current Electron version is v27.X which is EOL

Steps to Reproduce

See package.json dependencies

Possible Solution

Versions prior to Electron v29 are EOL, see.

Please upgrade version to >= v29.

Best regards
Jonas

Context

No response

Application version

0.7.1

Operating System and version

NixOS

Server and Version

Jellyfin latest

Node Version (if developing locally)

No response

@onny onny added the bug Something isn't working label Jun 12, 2024
@jeffvli jeffvli self-assigned this Jul 3, 2024
jeffvli added a commit that referenced this issue Jul 3, 2024
@jeffvli jeffvli closed this as completed Jul 3, 2024
@jeffvli jeffvli reopened this Jul 3, 2024
jeffvli added a commit that referenced this issue Jul 3, 2024
@jeffvli
Copy link
Owner

jeffvli commented Jul 3, 2024

This issue will require more attention due to Electron v28 introducing ESM as a breaking change.

#659

@jeffvli
Copy link
Owner

jeffvli commented Jul 3, 2024

Resolved in #659, updated electron to major version v31.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants